Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2: add some reverse deps to passthru.tests #331879

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Aug 3, 2024

Description of changes

This should be the norm for high-rebuild packages

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member

@trofi is currently bumping version on Staging:

#332071

@pbsds pbsds requested a review from cpages August 7, 2024 09:36
@pbsds
Copy link
Member Author

pbsds commented Aug 7, 2024

i used these deps to test and merge #324512, which is why i made this pr

@AndersonTorres
Copy link
Member

@cpages is dormant: #290642

@AndersonTorres
Copy link
Member

i used these deps to test and merge #324512, which is why i made this pr

Since we are here, what about including guile-sdl2?

@pbsds pbsds force-pushed the feat-sdl2-tests-1722642424 branch from d0dfe15 to 21835c8 Compare August 8, 2024 10:57
@pbsds pbsds merged commit 7de3f81 into NixOS:master Aug 8, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants