Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tigervnc: 0.13.1 -> 0.14.0 #331297

Merged
merged 1 commit into from
Sep 17, 2024
Merged

tigervnc: 0.13.1 -> 0.14.0 #331297

merged 1 commit into from
Sep 17, 2024

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Jul 31, 2024

Release log: https://github.com/TigerVNC/tigervnc/releases

There were some changes to the way that the xorg server is patched, see the files in https://github.com/TigerVNC/tigervnc/tree/master/unix. Things build with xorgserver 21 but I'm not sure about other versions.

I've also added libXrandr and libXdamage as dependencies because I get the following CMake warnings otherwise:

CMake Warning at unix/x0vncserver/CMakeLists.txt:38 (message):
  No DAMAGE extension.  x0vncserver will have to use the slower polling
  method.

CMake Warning at unix/x0vncserver/CMakeLists.txt:50 (message):
  No Xrandr extension.  x0vncserver will not be able to resize session.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@carbolymer
Copy link
Contributor

I'm wondering what's left here to have this merged?

@pbsbot
Copy link

pbsbot commented Sep 17, 2024

Result of nixpkgs-review pr 331297 run on x86_64-linux 1

1 package failed to build:
  • nemu
3 packages built:
  • crowbar
  • crowbar.dist
  • tigervnc

@pbsds
Copy link
Member

pbsds commented Sep 17, 2024

nemu already broken on hydra https://hydra.nixos.org/build/272607659

@pbsds
Copy link
Member

pbsds commented Sep 17, 2024

starts fine

@pbsds pbsds merged commit 005d3fd into NixOS:master Sep 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants