Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promscale_extension,buildPgxExtension: remove #305572

Merged
merged 2 commits into from
Apr 25, 2024
Merged

promscale_extension,buildPgxExtension: remove #305572

merged 2 commits into from
Apr 25, 2024

Commits on Apr 20, 2024

  1. postgresqlPackages.promscale_extension: remove deprecated and broken … 

    …package

postgresql14Packages.promscale_extension breaks with:

  Error:
    0: `pgx-0.6.1` shouldn't be used with `cargo-pgx-0.7.4`,
    please use `pgx = "~0.7.4"` in your `Cargo.toml`.

However, pinning cargo-pgx to 0_6_1 via the following

  buildPgxExtension.override { cargo-pgx = cargo-pgx_0_6_1; }

does not work either, because the build then fails with:

  thread 'main' panicked at /build/promscale_extension-0.8.0-vendor.tar.gz/proc-macro2/src/fallback.rs:756:9:
  "__mbstate_t_union_(unnamed_at_/nix/store/ij144ma6vs8acil8r9hgr8xkb1dp9azg-glibc-2_39-5-dev/include/bits/types/__mbstate_t_h_16_3)" is not a valid Ident

This seems to be related to [1], which indicates that this is a
problem with newer LLVM / clang toolchains.

At the same time th upstream package is deprecated / archived since
the 2nd of April 2024 [2]. Additionally this package is unfree and
thus very unlikely to be forked. Since we can't expect this to be
fixed, the only sensible thing to do is to remove the package.

[1]: rust-lang/rust-bindgen#2312
[2]: timescale/promscale#1836
    @wolfgangwalther
    wolfgangwalther committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    945a3bb View commit details
    Browse the repository at this point in the history

  2. buildPgxExtension: remove old versions 

    pgx had been renamed to pgrx in April 2023 already [1]. Newer versions
are already in nixpkgs as pgrx. Since the previous commit removed
the only remaining instance of a package still depending on
pgx 0.6.1, we can now remove all of buildPgxExtension and cargo-pgx.

[1]: pgcentralfoundation/pgrx#1106
    @wolfgangwalther
    wolfgangwalther committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    a0a1328 View commit details
    Browse the repository at this point in the history