Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib/0/rfc169 proof/out #284107

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Jan 26, 2024

Supporting code for proposed RFC0169

nix-repl> cmus.override { alsaSupport = false; }
trace: warning: Feature parameter 'alsaSupport' is deprecated in favor of 'with_alsa'.
«derivation /nix/store/jm87wmcnpibrxfzwz95i51zh2qdxxp32-cmus-2.10.0.drv»

nix-repl> cmus.override { with_alsa = false; }
«derivation /nix/store/jm87wmcnpibrxfzwz95i51zh2qdxxp32-cmus-2.10.0.drv»

@KAction
Copy link
Contributor Author

KAction commented Jan 27, 2024

I did some compraison of evaluation time. As far as time concerned, I can't see any difference, but stats for nix-instantiate -A cmus say:

-  "nrFunctionCalls": 640435,
+  "nrFunctionCalls": 648806,

which means 1.3% more function calls. If I evaluate something big, but without anything renamed, like emacs, I get following:

-  "nrFunctionCalls": 451758,
+  "nrFunctionCalls": 457842,

which is also 1.3% more function calls.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants