Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borgbackup: 1.2.6 -> 1.2.7 #271995

Merged
merged 1 commit into from
Dec 13, 2023
Merged

borgbackup: 1.2.6 -> 1.2.7 #271995

merged 1 commit into from
Dec 13, 2023

Conversation

999eagle
Copy link
Contributor

@999eagle 999eagle commented Dec 4, 2023

Description of changes

Changelog: https://github.com/borgbackup/borg/blob/1.2.7/docs/changes.rst#version-127-2023-12-02

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao
Copy link
Member

NickCao commented Dec 4, 2023

This update also allows the use of msgpack 1.0.7, we can revisit #256497

@Mindavi
Copy link
Contributor

Mindavi commented Dec 10, 2023

Some tests fail on Darwin

@999eagle
Copy link
Contributor Author

The failing darwin tests seem to be the same as #267536 and apparently have been failing since 1.2.4 due to timestamps being off by exactly 1 second. I don't have a darwin machine available to investigate why this fails though, sorry.

@Mindavi
Copy link
Contributor

Mindavi commented Dec 13, 2023

Okay well, I guess it's not a regression then, but it would still be nice if it was either marked broken for darwin or if someone that uses Darwin could look at it. I won't block the PR on this but hopefully someone can figure this out.

@Mindavi Mindavi merged commit 5c25ff3 into NixOS:master Dec 13, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants