Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more asynctest references on Python 3.11 #263783

Merged
merged 7 commits into from
Oct 28, 2023

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 27, 2023

Description of changes

The asynctest package was disabled for python 3.11 in 10c3f73.

This resulted in evaluation issues for the home-assistant-component-tests attribute set, since it moved to python3.11 in 2d29bf7.

This PR removes usages of asynctest on python3.11 for example by disabling test suites or removing obsolete packages.

cc #216168

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

We don't ship any Python that is older than 3.8 anymore.
Unmaintained for >5 years and removed from home-assistant earlier this
year leaving no consumers in nixpkgs.
They cannot run because asynctest is unsupported on python3.11.
They use asynctest, which is unsupported on python 3.11.
They use asynctest, which is incompatible with python 3.11.
@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 263783 run on x86_64-linux 1

12 packages built:
  • home-assistant-component-tests.intellifire
  • home-assistant-component-tests.melcloud
  • python310Packages.intellifire4py
  • python310Packages.intellifire4py.dist
  • python311Packages.intellifire4py
  • python311Packages.intellifire4py.dist
  • python311Packages.pymelcloud
  • python311Packages.pymelcloud.dist
  • python311Packages.pyversasense
  • python311Packages.pyversasense.dist
  • python311Packages.zigpy-cc
  • python311Packages.zigpy-cc.dist

@mweinelt mweinelt changed the title Remove asynctest references on Python 3.11 Remove more asynctest references on Python 3.11 Oct 27, 2023
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Oct 27, 2023
@ofborg ofborg bot requested review from fabaff, Mic92 and mvnetbiz October 27, 2023 14:21
@mweinelt mweinelt merged commit f177b76 into NixOS:master Oct 28, 2023
29 checks passed
@mweinelt mweinelt deleted the operation-asynctest branch October 28, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant