Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: 0.29.2 -> 0.30.0 #256072

Merged
merged 1 commit into from
Sep 20, 2023
Merged

kitty: 0.29.2 -> 0.30.0 #256072

merged 1 commit into from
Sep 20, 2023

Conversation

kashw2
Copy link
Contributor

@kashw2 kashw2 commented Sep 19, 2023 •
edited
Loading

Description of changes

closes: #256048

change log: https://github.com/kovidgoyal/kitty/releases/tag/v0.30.0 https://sw.kovidgoyal.net/kitty/changelog/#id1

diff: kovidgoyal/kitty@v0.29.2...v0.30.0

updated version of go used to 1.21
added xxHash dep to buildInputs as kitty now requires libxxhash
added myself as a maintainer of kitty

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kashw2
Copy link
Contributor Author

kashw2 commented Sep 19, 2023

Result of nixpkgs-review pr 256072 run on x86_64-linux 1

4 packages built:
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo

@kashw2
Copy link
Contributor Author

kashw2 commented Sep 19, 2023 •
edited
Loading

failing passthru tests on x86_64-darwin may be related to kovidgoyal/kitty#6636

@adamcstephens
Copy link
Contributor

Considering the diff on the test failure is mtime related, I suspect it's not the same as that powerpc64 issue. Likely it's a non-reproducible test that needs to be patched or disabled.

@kashw2 kashw2 force-pushed the kitty branch 2 times, most recently from bbfff39 to 1908e15 Compare September 19, 2023 13:36
@ofborg ofborg bot requested a review from adamcstephens September 20, 2023 00:10
@ofborg ofborg bot requested a review from adamcstephens September 20, 2023 09:40
adamcstephens
adamcstephens approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 256072 run on x86_64-linux 1

4 packages built:
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo

Result of nixpkgs-review pr 256072 run on aarch64-linux 1

4 packages built:
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo

Result of nixpkgs-review pr 256072 run on x86_64-darwin 1

4 packages built:
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo

Result of nixpkgs-review pr 256072 run on aarch64-darwin 1

4 packages built:
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo

@adamcstephens adamcstephens added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 20, 2023
@fabianhjr fabianhjr added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Sep 20, 2023
@fabianhjr fabianhjr merged commit 34fe3fa into NixOS:master Sep 20, 2023
11 checks passed
@kashw2 kashw2 deleted the kitty branch September 20, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcstephens adamcstephens adamcstephens approved these changes

@fabianhjr fabianhjr fabianhjr approved these changes

@tex tex Awaiting requested review from tex

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

@Luflosi Luflosi Awaiting requested review from Luflosi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: kitty 0.29.2 → 0.30.0
3 participants
@kashw2 @adamcstephens @fabianhjr