python3Packages.mocket: Resolve test failures #216511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
reviewed
Feb 15, 2023
Comment on lines
77
to
79
| "test_http_session" | ||
| "test_https_session" | ||
| "test_httprettish_session" |
There was a problem hiding this comment.
Set __darwinAllowLocalNetworking = true; instead.
There was a problem hiding this comment.
Thanks, I didn't know about that! However, I'm not sure if it's even a Darwin-specific issue anymore -see below
|
The tests also fail on x86_64-linux for me (even with the sandbox disabled). (printed a couple of times) That would mean it's simply an upstream Python 3.11 compatibility issue. |
|
Result of 2 packages marked as broken and skipped:
11 packages failed to build:
16 packages built:
Edit:
geoip2 test output (excerpt): |
Add pytest-asyncio in order to allow async tests to run. They were previously silently skipped with a warning. Disable three more tests (test_http*_session) that depend on Internet connectivity and thus fail in sandboxed builds.
hesiod
force-pushed
the
python-mocket
branch
from
1848879
to
58fd39a
Compare
|
After more fiddling, I think the root issue is simply some Python 3.11 incompatibility in the test setup of mocket (althought I'm not sure what the cause is). Anyways, in the newest version of the commits I'm conditionally disabling certain tests on Python >= 3.11 in mocket and geoip2 - the latter has similar 3.11 issues that weren't uncovered previously because mocket didn't build. |
|
Result of 2 packages marked as broken and skipped:
1 package failed to build:
26 packages built:
sopel issue maybe unrelated: |
davidak
approved these changes
Feb 17, 2023
|
#217295 contains the update of |
fabaff
reviewed
Feb 20, 2023
| @@ -30,6 +30,8 @@ buildPythonPackage rec { | |||
| pytestCheckHook | |||
| ]; | |||
|
|
|||
| disabledTests = lib.optional (pythonAtLeast "3.11") "TestAsyncClient"; | |||
There was a problem hiding this comment.
For me there was also a failure on Python 3.10, see e2be015
12 tasks
figsoda
added
the
12.approvals: 1
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add pytest-asyncio in order to allow async tests to run. They were previously silently skipped with a warning.
Disable three more tests (test_http*_session) that depend on Internet connectivity and thus fail in sandboxed builds.
This should some Hydra failures, e.g. this one: https://hydra.nixos.org/build/208832590
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)