Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buck: mark broken on aarch64-darwin #215575

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

andrewhamon
Copy link
Contributor

@andrewhamon andrewhamon commented Feb 9, 2023

Description of changes

Buck is broken on aarch64-darwin. In particular, it is broken in such a way that the job dies but nix doesn't see that, so it just hangs for 2 hours before timing out.

I noticed this when trying to run nixpkgs-review for an update to watchman, a dependency of buck.

@jgertm @marsam

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Feb 9, 2023
@azuwis
Copy link
Contributor

azuwis commented Feb 10, 2023

https://hydra.nixos.org/job/nixpkgs/nixpkgs-unstable-aarch64-darwin/buck.aarch64-darwin/all?page=3

Buck was able to built at 2021-06-04, but failed at 2021-06-05 for the some version.

I think a jdk change causes the failure.

@wegank
Copy link
Member

wegank commented Feb 10, 2023

facebook/buck#2666

@wegank wegank merged commit 17a3ebd into NixOS:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants