Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cupy: mark as broken #185313

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Conversation

samuela
Copy link
Member

@samuela samuela commented Aug 5, 2022

Description of changes

See #179912 (comment). Cupy has been broken for a minute. This PR just marks it as such for the sake of CI/nixpkgs-review.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@winterqt
Copy link
Member

winterqt commented Aug 5, 2022

@ofborg eval

@samuela
Copy link
Member Author

samuela commented Aug 5, 2022

eval is hopefully fixed after rebasing to latest master in f77deac

@winterqt
Copy link
Member

winterqt commented Aug 5, 2022

eval is hopefully fixed after rebasing to latest master in f77deac

For what it's worth, OfBorg automatically merges your changes into master, if that's what you were worried about.

@samuela
Copy link
Member Author

samuela commented Aug 5, 2022

For what it's worth, OfBorg automatically merges your changes into master, if that's what you were worried about.

I believe eval was broken on master due to my own goof in #179912. So I believe a rebase was necessary 🤷‍♂️

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 5, 2022
@jonringer jonringer merged commit 2c5f5c7 into NixOS:master Aug 6, 2022
@samuela samuela deleted the samuela/cupy branch August 6, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants