-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hass nabucasa.0.37.1 #101958
Hass nabucasa.0.37.1 #101958
Conversation
0f6b83b
to
da39db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see multiple disabled test cases which have had its issues fixed. Please reenable them.
hey I can only find one, and that one is still needed because the issue is closed but not fixed in that 3.2.0 release |
|
the test to short issue has been closed, but the test still requires ecdsa<0.15 which we dont have in nixpkgs since its 0.15 |
On second thought, let's not do that. But please enable the hass-nabucasa tests. |
asynctest is still broken on python 3.8 as far as i read this issue Martiusweb/asynctest#132 |
da39db7
to
32fdd1b
Compare
done enabled tests for python 3.8 |
32fdd1b
to
da2e834
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Motivation for this change
upgrade hass-nabucasa and deps
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)