Skip to content

Commit

Permalink
python312Packages.mlx: upgrade and fix build (#367011)
Browse files Browse the repository at this point in the history
  • Loading branch information
doronbehar authored Dec 23, 2024
2 parents a710670 + 32ff266 commit 52fc4c0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
4 changes: 2 additions & 2 deletions pkgs/by-name/op/openmpi/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,14 @@ stdenv.mkDerivation (finalAttrs: {
zlib
libevent
hwloc
prrte
]
++ lib.optionals stdenv.hostPlatform.isLinux [
libnl
numactl
pmix
ucx
ucc
prrte
]
++ lib.optionals cudaSupport [ cudaPackages.cuda_cudart ]
++ lib.optionals (stdenv.hostPlatform.isLinux || stdenv.hostPlatform.isFreeBSD) [ rdma-core ]
Expand All @@ -119,7 +119,7 @@ stdenv.mkDerivation (finalAttrs: {
"--with-pmix=${lib.getDev pmix}"
"--with-pmix-libdir=${lib.getLib pmix}/lib"
# Puts a "default OMPI_PRTERUN" value to mpirun / mpiexec executables
(lib.withFeatureAs stdenv.hostPlatform.isLinux "prrte" (lib.getBin prrte))
(lib.withFeatureAs true "prrte" (lib.getBin prrte))
(lib.withFeature enableSGE "sge")
(lib.enableFeature enablePrefix "mpirun-prefix-by-default")
# TODO: add UCX support, which is recommended to use with cuda for the most robust OpenMPI build
Expand Down
2 changes: 1 addition & 1 deletion pkgs/by-name/pr/prrte/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ stdenv.mkDerivation rec {
homepage = "https://docs.prrte.org/";
license = lib.licenses.bsd3;
maintainers = with lib.maintainers; [ markuskowa ];
platforms = lib.platforms.linux;
platforms = lib.platforms.unix;
};
}
9 changes: 6 additions & 3 deletions pkgs/development/python-modules/mlx/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ let
in
buildPythonPackage rec {
pname = "mlx";
version = "0.18.0";
version = "0.21.1";

src = fetchFromGitHub {
owner = "ml-explore";
repo = "mlx";
rev = "refs/tags/v${version}";
hash = "sha256-eFKjCrutqrmhZKzRrLq5nYl0ieqLvoXpbnTxA1NEhWo=";
hash = "sha256-wxv9bA9e8VyFv/FMh63sUTTNgkXHGQJNQhLuVynczZA=";
};

pyproject = true;
Expand Down Expand Up @@ -83,6 +83,9 @@ buildPythonPackage rec {
changelog = "https://github.com/ml-explore/mlx/releases/tag/v${version}";
license = licenses.mit;
platforms = [ "aarch64-darwin" ];
maintainers = with maintainers; [ viraptor ];
maintainers = with maintainers; [
viraptor
Gabriella439
];
};
}

0 comments on commit 52fc4c0

Please sign in to comment.