-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardware support for Lenovo LOQ 15aph8 #1206
base: master
Are you sure you want to change the base?
Conversation
f014c36
to
ddeb41e
Compare
Please undraft if you are done with it. |
ty for your review.
will do! |
3ded672
to
829cfb2
Compare
829cfb2
to
50e35e3
Compare
hardware.nvidia.modesetting.enable = lib.mkDefault true; | ||
services.thermald.enable = lib.mkDefault true; | ||
|
||
# These will merge with user settings, so no mkDefault needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it merge with user settings? As far as I can see this requires 'lib.mkForce', no?
|
||
# Power management - using mkDefault as these can be overridden | ||
hardware.nvidia.powerManagement.enable = lib.mkDefault true; | ||
hardware.nvidia.modesetting.enable = lib.mkDefault true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC the nvidia.modesetting
line is implied by the call to gpu/nvidia/ada-lovelace
, as it calls gpu/nvidia
, containing this same line.
(Notably the mentioned PR there is already merged)
|
||
# Power management - using mkDefault as these can be overridden | ||
hardware.nvidia.powerManagement.enable = lib.mkDefault true; | ||
hardware.nvidia.modesetting.enable = lib.mkDefault true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardware.nvidia.modesetting.enable = lib.mkDefault true; |
Things done
nixos-hardware
andimporting it via
<nixos-hardware>
or Flake input