Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move trailing comments in let anymore #270

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piegamesde
Copy link
Member

Split out from #269 to delay it until after the Nixpkgs treewide


While this was initially introduced for good reasons, as can also be seen in the diff, that code was written with documentation comments in mind and not code comments. As per the bug report, the downsides were deemed to high to keep it in

Fixes #259

While this was initially introduced for good reasons, as can also be
seen in the diff, that code was written with documentation comments in
mind and not code comments. As per the bug report, the downsides were
deemed to high to keep it in

Fixes NixOS#259
Copy link

github-actions bot commented Dec 3, 2024

Nixpkgs diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

Suggestion: commented out lines at the end of a let block should stay in the let block
1 participant