RFC 166 implementation tracking issue

[infinisil]

Now that RFC 166 is accepted, let's commence with the implementation!

Here's a very rough todo-list, most of which will be fairly quick.

• Update README to mention WIP state: readme: Add status note #154
• Create Nix formatting GitHub team: https://github.com/orgs/NixOS/teams/nix-formatting/members
  • Add @Sereja313 to the team, couldn't do that myself since they're not already in the organisation. This was requested in the issue below
• Move repo under NixOS org: Transfer to NixOS GitHub organisation #155
• Decide on merge rules: https://github.com/NixOS/nixfmt/rules/523613?ref=refs%2Fheads%2Fmaster
• Create a team page in the repo: Create team document #156
• Create a GitHub project board
  Let's only start using one if we feel the need for it
• Create a nixos.org page for the team: Add formatting team nixos-homepage#1337
• Move the RFCs initial standard format into the repo: import initial standard formatting #158
• Merge RFC 101/166 style #118
• Set up automated testing
  • Run test suite in CI: ci: run tests #172
  • Each PR needs to be tested on the entirety of Nixpkgs: Test on Nixpkgs #163
• Fully review the code
  • Check that it conforms to the specification
  • Document sufficiently
  • Simplify if possible
• Tool documentation
• Create a release and announce it
  • Marketing, celebration, Discourse, blog post, NixCon talk, etc.
  • Update Nixpkgs and Nix docs, e.g. contributor guide, etc.
• Update nix fmt to point to nixfmt: WIP: feat(fmt): use nixfmt-rfc-style nix#11252
• Reformat Nixpkgs: Reformat Nixpkgs nixpkgs#322520
  • Also on other repos
  • Also, Nix code in documentation and elsewhere

Ping @piegamesde @tomberek @0x4A6F @Sereja313 @dasJ

[tomberek]

Proposal: do reformatting in the NixOS org with a few non-nixpkgs repos first

[Atemu]

Proposal: After what @tomberek suggested is done and successful, do formatting of Nixpkgs in a subset of Nixpkgs first (i.e. pkgs/by-name/)

[Kreyren]

https://github.com/Kreyren/nixos-config/blob/dc0dbb6f15c4d8656b26220645793a06d10fa3ea/nixos/users/kreyren/home/modules/prompts/starship/starship.nix#L3-L14 (best seen in raw)

RFC @infinisil Is this known issue that is actionable by RFC166? I read through it don't see it anywhere (if tabs are used it causes the prompt to be rendered with long indentation instead of the indentation being removed from the declaration, affects most of nix modules)

[piegamesde]

This looks unlikely to be a desired output according to the RFC format. Now that the PR is merged, please simply open an issue for it.

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-03-19/41845/1

[Kreyren]

This looks unlikely to be a desired output according to the RFC format. Now that the PR is merged, please simply open an issue for it. -- @piegamesde (#153 (comment))

Referencing comment by @roberth in NixOS/nix#8874 (comment)

Got referred to RFC166 from RFC137 about this issue in relation to addressing NixOS/nix#8874

[piegamesde]

@Kreyren please just open a new issue with input, current output and desired output and I'll look at it. Simply linking to weird looking code does not give me enough context to understand the situation.

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-56/43035/1

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixf-tidy-static-semantic-linter-for-nix-help-me-to-integrate-it-with-github-actions-pr-reviews/43911/2

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/enforcing-nix-formatting-in-nixpkgs/49506/3

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/enforcing-nix-formatting-in-nixpkgs/49506/8

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/satisfaction-survey-from-the-new-rfc-166-formatting/49758/1

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/why-does-the-nixos-infrastructure-have-to-be-hosted-in-a-centralized-way/46789/36

[gabyx]

@infinisil et. al.: ❤️ Thanks a lot for pushing this and the hard work on it! I am happy if that debate is soon over =) and we have some opiniated way to not disgress again and again into whitespace debates in PRs. Having a 90% solution is so much better then having nothing which puts Nixpkgs back to middleages.