Give unit tests access to a $HOME directory #13370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, don't try to access cache.nixos.org in the libstore unit tests.
edolstra
commented
Jun 17, 2025
| @@ -60,6 +60,7 @@ test( | |||
| env : { | |||
| '_NIX_TEST_UNIT_DATA': meson.current_source_dir() / 'data', | |||
| 'NIX_CONFIG': 'extra-experimental-features = flakes', | |||
| 'HOME': meson.current_build_dir() / 'test-home', | |||
There was a problem hiding this comment.
Note: it would be better to use a temporary directory here, but I don't know how to do that in Meson.
There was a problem hiding this comment.
mesonbuild/meson#14733 forwarding your question
xokdvium
reviewed
Jun 17, 2025
Comment on lines
+62
to
+63
| export HOME="$TMPDIR/home" | ||
| mkdir -p "$HOME" |
There was a problem hiding this comment.
Nixpkgs now has writableTmpDirAsHomeHook. Seems like a good fit for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows them to not skip some tests that require a home directory (like anything that uses the fetcher cache).
Also, don't try to access cache.nixos.org in the libstore unit tests because that's bad for reproducibility.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.