Stores no longer inherit from their configs #13154
Conversation
github-actions
bot
added
documentation
new-cli
Ericson2314
force-pushed
the
split-store-config
branch
from
e1acf3d to
d3a56fa
Compare
|
@xokdvium I think the constructor for I am not sure how to fix this with the old settings system. Of course, my new store settings system in #11139 is designed to fix just these sorts of issues, but the point of splitting out this PR was to not do that refactor just yet. Any ideas? (I am running UBSAN right now to check this hypothesis.) |
theory was correct |
Ericson2314
force-pushed
the
split-store-config
branch
from
d3a56fa to
8598565
Compare
|
Solved an OOP problem with more OOP 🥴 |
Fix NixOS#10766 See that ticket for details. Progress (I hope!) towards NixOS#11139. Co-Authored-By: Sergei Zimmerman <[email protected]>
Ericson2314
force-pushed
the
split-store-config
branch
from
8598565 to
934918b
Compare
|
Big thanks to @xokdvium for figuring out the bug with |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2025-05-14-nix-team-meeting-minutes-226/64298/1 |
| * Need to make this a separate class so I can get the right | ||
| * initialization order in the constructor for `StoreDirConfig`. | ||
| */ | ||
| struct StoreDirConfigItself : Config |
context: #13154 (comment) (cherry picked from commit 2dd2142)
Motivation
Fix #10766
Context
See that ticket for details.
Progress (I hope!) towards #11139.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.