Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: make sure we can always test the installer in ci and locally (backport #12059) #12075

Open
wants to merge 2 commits into
base: 2.25-maintenance
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 16, 2024

Just now there is a dependency on cachix, which means we cannot test the installer in CI if forks do not have the necessary secrets set up. We replace this with a simple http server that serves the installer and can be both used in CI and locally.

Another nice side effect is that now every pull request has a downloadable installer: https://github.com/NixOS/nix/actions/runs/12340760590

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.


This is an automatic backport of pull request #12059 done by [Mergify](https://mergify.com).

Just now there is a dependency on cachix, which means we cannot test
the installer in CI if forks do not have the necessary secrets set up.
We replace this with a simple http server that serves the installer and
can be both used in CI and locally.

(cherry picked from commit 6162e12)

# Conflicts:
#	.github/workflows/ci.yml
#	flake.nix
(cherry picked from commit df3eb4f)
Copy link
Contributor Author

mergify bot commented Dec 16, 2024

Cherry-pick of 6162e12 has failed:

On branch mergify/bp/2.25-maintenance/pr-12059
Your branch is up to date with 'origin/2.25-maintenance'.

You are currently cherry-picking commit 6162e1220.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   packaging/hydra.nix
	modified:   scripts/prepare-installer-for-github-actions
	new file:   scripts/serve-installer-for-github-actions

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ci.yml
	both modified:   flake.nix

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant