Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Firefox module ready to work with Gnome extension #31

Open
wants to merge 1 commit into
base: calamares
Choose a base branch
from
Open

Make Firefox module ready to work with Gnome extension #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion modules/nixos/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@
# services.xserver.libinput.enable = true;

"""

cfgusers = """ # Define a user account. Don't forget to set a password with ‘passwd’.
users.users.@@username@@ = {
isNormalUser = true;
Expand All @@ -260,7 +261,13 @@
"""

cfgfirefox = """ # Install firefox.
programs.firefox.enable = true;
programs.firefox = {
enable = true;
package = pkgs.firefox;
nativeMessagingHosts.packages = with pkgs; [
browserpass
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If installing it is a too big change, we could do the same than for Thunderbird, just suggesting it by writting it but commenting it like

    nativeMessagingHosts.packages = with pkgs; [
      # browserpass

This way, it won't change installation process at all but it will make it very much easier for new comers to find out how to activate it and make Firefox work with Gnome extension and also.

It would also give indication where the user should add thing like
gnomeExtensions.gsconnect or firefoxpwa :

    nativeMessagingHosts.packages = with pkgs; [
      browserpass
      gnomeExtensions.gsconnect
      firefoxpwa
    ];
  };

];
};

"""

Expand Down Expand Up @@ -323,6 +330,7 @@
system.stateVersion = "@@nixosversion@@"; # Did you read the comment?

}

"""


Expand Down