hackage-db: Fix the type of signatures in metadata #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signatures are actually complex objects. We could use `Value` here since it's unlikely that any consumers care about this, but it's cheap enough to just define a structure for the signature objects. In practice this isn't an issue because it seems like this field is never populated in Hackage, but it can be populated if you build a custom Hackage it can happen. Fixes #573.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR/discussion: NixOS/hackage-db#17
Signatures are actually complex objects. We could use
Valuehere since it's unlikely that any consumers care about this, but it's cheap enough to just define a structure for the signature objects.In practice this isn't an issue because it seems like this field is never populated in Hackage, but it can be populated if you build a custom Hackage it can happen.
Fixes #573.
cc @michaelpj (sorry for the repository moving mess)