Get rid of libusbio #523
Closed
Get rid of libusbio #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj-so
reviewed
Jun 20, 2024
|
updated PR desc |
|
Tested on macOS 14 (ARM64). Listing and reading the version works. Then I attempted an update of the NK3. This fails, leaving the NK3 in bootloader mode. Running the update again returns the same error. Removing the forced two-step update process has the same outcome. |
|
ah ok - the error on mac is the same as on linux: quite obviously it is not using |
daringer
force-pushed
the
spsdk-vendor-libusbsio
branch
from
f54e7bd
to
300ee7d
Compare
|
works with lpc on linux for me now, @mmerklinger please check |
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 6, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 This introduces a dependency on the hidapi library. If the library is not present when trying to list or open a LPC55 bootloader device, an exception will be raised. Co-authored-by: Sosthène Guédon <[email protected]>
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 6, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 This introduces a dependency on the hidapi library. Per default, the hid module raises an exception if hidapi is not present. We catch this exception and show a warning instead so that the SDK can still be used for other devices if hidapi is missing. Co-authored-by: Sosthène Guédon <[email protected]>
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 6, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 It introduces a dependency on the hidapi library. Per default, the hid module raises an exception if hidapi is not present. We catch this exception and show a warning instead so that the SDK can still be used for other devices if hidapi is missing. Co-authored-by: Sosthène Guédon <[email protected]>
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 6, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 It introduces a dependency on the hidapi library. Per default, the hid module raises an exception if hidapi is not present. We catch this exception and show a warning instead so that the SDK can still be used for other devices if hidapi is missing. Co-authored-by: Sosthène Guédon <[email protected]>
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 7, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 If the hid module cannot be loaded, a warning is raised so that the SDK can still be used for other devices if hidapi is not working correctly. Co-authored-by: Sosthène Guédon <[email protected]>
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 7, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 If the hid module cannot be loaded, a warning is raised so that the SDK can still be used for other devices if hidapi is not working correctly. Co-authored-by: Sosthène Guédon <[email protected]>
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 12, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 If the hid module cannot be loaded, a warning is raised so that the SDK can still be used for other devices if hidapi is not working correctly. Co-authored-by: Sosthène Guédon <[email protected]>
robin-nitrokey
added a commit
to Nitrokey/nitrokey-sdk-py
that referenced
this pull request
Aug 12, 2024
This commit is extracted from: Nitrokey/pynitrokey#523 If the hid module cannot be loaded, a warning is raised so that the SDK can still be used for other devices if hidapi is not working correctly. Co-authored-by: Sosthène Guédon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing on windows and macos
edit: meissner hijacking this
hidstuff I don't understand @daringer - fixed)