-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PIV commands #506
base: master
Are you sure you want to change the base?
Add PIV commands #506
Conversation
7d4b88f
to
7062bc1
Compare
Not sure how to deal with the modules that don't have type definitions. How can I just ignore the errors for pyscard and asn1crypto? I don't think we can get rid of those, or add type checks.
|
Generally, there are two solutions to dependencies without type annotations:
Obviously, the first option is much better, but not always worth the effort, especially for legacy code. See the Also make sure to check the typeshed repository. Maybe somebody already wrote a stub. |
919fe51
to
d24302b
Compare
I've found a bug testing this branch with the 1.6.0-test firmware
|
Thank you for the report. It was a very simple typo, fixed in d5bc2af |
It has only 3 github stars, and is mostly unused
d5bc2af
to
2575540
Compare
f072dcf
to
c802f4a
Compare
9500d28
to
fe33e39
Compare
fe33e39
to
a2cdd32
Compare
316003a
to
452c808
Compare
This PR adds PIV commands under
nitropy nk3 piv
Checklist
Make sure to run
make check
andmake fix
before creating a PR, otherwise the CI will fail.If we merge this before PIV is stabilised, this will need to be behind a
--experimental
flag.