Reverse mypy exceptions #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of disabling strict checks per default and only enabling them for new code, this patch enables strict checks per default and disables them for old code. This makes sure that new code is not accidentally ignored. This patch also fixes some simple typing issues so that we can drop some exceptions.
daringer
approved these changes
Nov 21, 2023
|
on the path to full type hinting, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of disabling strict checks per default and only enabling them for new code, this patch enables strict checks per default and disables them for old code. This makes sure that new code is not accidentally ignored.
This patch also fixes some simple typing issues so that we can drop some exceptions.
This is a preparation for adding type checks for the nethsm module and extending the fido2 module.