Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the nethsm-sdk-py library #450

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Use the nethsm-sdk-py library #450

merged 1 commit into from
Sep 29, 2023

Conversation

nponsard
Copy link
Contributor

@nponsard nponsard commented Sep 28, 2023 •
edited
Loading

This PR changes the nethsm CLI to use nethsm-sdk-py

Changes

  • add dependency on the nethsm pypi package
  • remove makefile options related to the generation of the nethsm client
  • remove the old nethsm client
  • remove handling of requests exception for NetHSM commands (the module doesn't use requests anymore)
  • remove direct dependency on urllib3

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)

Test Environment and Execution

  • OS: Arch

@nponsard nponsard changed the title feat: use the nethsm-sdk-py library Use the nethsm-sdk-py library Sep 28, 2023
@nponsard nponsard marked this pull request as ready for review September 28, 2023 09:22
@nponsard nponsard marked this pull request as draft September 29, 2023 08:44
@nponsard nponsard marked this pull request as ready for review September 29, 2023 09:01
@nponsard nponsard mentioned this pull request Sep 29, 2023
Closed
robin-nitrokey
robin-nitrokey approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jans23 jans23 merged commit abf42ef into Nitrokey:master Sep 29, 2023
5 checks passed
@nponsard nponsard deleted the pr/nponsard/use-nethsm-sdk branch September 29, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nponsard @robin-nitrokey @jans23