nk3 test/fido2: early exit if pin not set - fixes #411

[daringer]

Remove pin prompt from nk3 test, if fido2 is activated and pin is required (set) on the target device.

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

• tested with Python3.11
• signed commits

Test Environment and Execution

• OS: Arch
• device's model: nk3am
• device's firmware version: 1.5

Relevant Output Example

❯ nitropy nk3 test 
Command line tool to interact with Nitrokey devices 0.4.39
Found 1 Nitrokey 3 device(s):
- Nitrokey 3 at /dev/hidraw12
Critical error:
FIDO2 tests activated: Device requires pin, but not set

Fixes #411

[robin-nitrokey]

Shouldn’t this just fail the fido2 test case instead of aborting all tests?

[daringer]

that was the other option I had in mind, will do

[daringer]

now it's like that:

❯ nitropy nk3 test
Command line tool to interact with Nitrokey devices 0.4.39
Found 1 Nitrokey 3 device(s):
- Nitrokey 3 at /dev/hidraw9

Running tests for Nitrokey 3 at /dev/hidraw9

[1/4]	uuid     	UUID query              	SUCCESS  	xxxxxxxxxxxxxxxxxxx
[2/4]	version  	Firmware version query  	SUCCESS  	v1.5.0
[3/4]	status   	Device status           	SUCCESS  	Status(init_status=<InitStatus: 0>, ifs_blocks=214, efs_blocks=457, variant=<Variant.NRF52: 2>)
[4/4]	fido2    	FIDO2                   	FAILURE  	FIDO2 pin is set, but not provided

4 tests, 3 successful, 0 skipped, 1 failed

Summary: 1 device(s) tested, 0 successful, 1 failed

[daringer]

but I broke some typing ... fixed....

[robin-nitrokey]

Thanks, that’s better! Maybe mention the --pin option in the error message.