Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SE050_RAND_ERROR reporting in status #436

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

sosthene-nitrokey
Copy link
Contributor

This PR adds reporting of SE050 initialization errors as introduced in Nitrokey/nitrokey-3-firmware@0bc4cde.

  • tested with Python 3.11.5
  • signed commits

Relevant Output Example

UUID:               DF776FB18D7DFE800000000000000000
Firmware version:   v1.5.0-test.20230704
Init status:        UNKNOWN (0x10)
Free blocks (int):  255
Free blocks (ext):  473
Variant:            NRF52

Becomes

UUID:               DF776FB18D7DFE800000000000000000
Firmware version:   v1.5.0-test.20230704
Init status:        SE050_RAND_ERROR (0x10)
Free blocks (int):  255
Free blocks (ext):  473
Variant:            NRF52

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add other error types for the SE050 or could we also just call it SE050_ERROR?

@sosthene-nitrokey
Copy link
Contributor Author

I don't see any other now. And indeed the error can include initialization errors.

Maybe it should be SE050_INIT_ERROR? I'm fine with either.

@robin-nitrokey
Copy link
Member

As this is called InitStatus, I think we don’t need another INIT, but both options are fine for me.

@sosthene-nitrokey
Copy link
Contributor Author

Ok!

I renamed it to SE050_ERROR.

@robin-nitrokey robin-nitrokey merged commit ae2ea31 into master Oct 27, 2023
10 checks passed
@robin-nitrokey robin-nitrokey deleted the se050-init-error branch October 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants