Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Try to use pkg-config for hidapi on macOS #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CMake: Try to use pkg-config for hidapi on macOS #141

wants to merge 1 commit into from

Conversation

muellermartin
Copy link
Contributor

Try to use CMake's module for pkg-config to find an installed version of HIDAPI and fall back to the current solution (local copy of HIDAPI in the source tree).

This fixes #140.

@szszszsz
Copy link
Member

Hi!
As mentioned in the source issue, was the libnitrokey build linked against homebrew's hidapi working for you? I had different experiences in the past, and recently similar issue has shown in other project: d-e-s-o/nitrocli#39.

@muellermartin muellermartin mentioned this pull request Jan 14, 2019
Open
@muellermartin
Copy link
Contributor Author

As mentioned in the related issue, the build currently works for me (compiles and test_safe passes). Maybe I will look into the issue to find out why it did not work in the past.

@szszszsz
Copy link
Member

I see. Which version of the homebrew package of libhidapi do you use?

@muellermartin
Copy link
Contributor Author

Which version of the homebrew package of libhidapi do you use?

As stated in the related issue, I'm using stable 0.8.0-rc1 (currently the latest version).

@szszszsz szszszsz added this to the v3.6 milestone Jul 10, 2019
@szszszsz szszszsz added the macOS label Jun 15, 2020
szszszsz
szszszsz approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@szszszsz szszszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Will be merged after brief tests / rebase

@szszszsz szszszsz added the test label Jun 15, 2020
@szszszsz szszszsz modified the milestones: v3.7, v3.8 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szszszsz szszszsz szszszsz approved these changes

Assignees
No one assigned
Labels
macOS test
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.

CMake does not find installed HIDAPI on macOS
2 participants
@muellermartin @szszszsz