-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create full version of the project - Space Travelers Hub #45
Conversation
Create the React app and install basic dependencies - Setup
Create empty My profile - Setup
Rockets structure
Create basic structure for Missions - Setup
Fetch missions data
β¦ and test the results
β¦ore in test environment
β¦omponent render
Create the tests cases for the components and functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NitBravoA92 & @Kidd254 π,
Your project is complete! You've done outstanding work here from the awesome UI down to the last bit of code, so...there is nothing else to say other than... it's time to merge it.
Congratulations! π π₯³π₯
Highlights
- UI is looking great β
- React Redux, Redux Logger, and React Router are properly configured β
- Local & global states are properly handled β
- API endpoints are properly called β
- Actions are properly dispatched β
- Correct use of Git Flow β
- Well-structured files β
- All linter checks are passing β
- Descriptive PR title with a top-notch summary β
Optional suggestions
- N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
React & Redux project. π₯
Team:
@NitBravoA92
@Kidd254
To build this project, the following requirements were fulfilled:
General requirements
β Follow the Gitflow pattern
β Distribute the work based on a Kanban board
β Create and set up a React project with create-react-app
β Use Redux Toolkit / React Redux to manage the global state of the application
β Use React Router to create the navigation routes.
β Create unit tests using Jest and React Testing Libraries
β Build the following interfaces: Rockets, Missions, and My Profile.
β Apply the Conditional Components Rendering approach to render different markups if a condition is true or false.
β Follow the design of the provided wireframes.
β Have no linter errors.
β Project documented correctly.
Coding requirements
β Header: A navigation menu is created in this section using the
<NavLink />
component of React Router to display the navigation links to the different pages. When the user clicks on any navigation link, the corresponding view is displayed and the selected link is underlined, so the user knows at all times which view is active. In addition to the navigation menu, the Logo and title of the web page are also displayed in the Header.β Rockets view: Upon loading the page, the web application retrieves data from the selected API (https://api.spacexdata.com/v4/rockets) using the
useDispatch()
hook to dispatch thegetAllRockets
action that updates the rockets state. This functionality allows to display the list of rockets items on the screen.Reserve Rocket
button of a rocket item, the actionaddReserve
is dispatched using theuseDispatch()
hook, and the rockets state is updated. The rocket's item information is updated on the screen displaying a blue badge with the textreserved
and aCancel Reservation
button.Cancel Reservation
button of a rocket item, the actioncancelReserve
is dispatched using theuseDispatch()
hook, and the rockets state is updated. The rocket's item information is updated on the screen by removing the blue badge with the textreserved
and theCancel Reservation
button and displaying theReserve Rocket
button again.β Missions view: Upon loading the page, the web application retrieves data from the selected API (https://api.spacexdata.com/v3/missions) using the
useDispatch()
hook to dispatch thegetAllMissions
action that updates the missions state. This functionality allows displaying the list of missions on the screen. This data is displayed using an HTML<table>
element.Join Mission
button of a mission item, the actionaddReservedMission
is dispatched using theuseDispatch()
hook, and the missions state is updated. The mission's item information is updated on the screen by removing the grayNOT A MEMBER
badge and theJoin Mission
button and displaying a new blue badge with the textActive Member
and aLeave Mission
button.Leave Mission
button of a mission item, the actionLeaveMission
is dispatched using theuseDispatch()
hook, and the missions state is updated. The mission's item information is updated on the screen by removing the blue badge with the textActive Member
and theLeave Mission
button and displaying again theNOT A MEMBER
badge and theJoin Mission
button.β My Profile view: Upon loading the page, the web application gets the
Reserved Rockets
andJoined Missions
data from the rockets and missions state using theuseSelector()
hook. This information is displayed on the screen in two columns with the titles My Missions and My Rockets. When the status of rockets and missions changes (for example, when you reserve a new rocket or leave a mission), the My Profile view also changes, showing an updated listing.The state updates are not preserved in the API.
Additional: The application has been successfully deployed. Live Demo link in the documentation.
βTo the code reviewer π¨βπ»
π We really thank πββοΈ you, dear code reviewer π¨βπ¨ for dedicating your precious π₯ time β to check the PR π§Ύ .
We kindly ask π dear code reviewer π€΅ that if there is any kind of issue π¦― in this project, please do list π them in a descriptive π‘ manner and give your best suggestions π if needed.
If you think there are some big issues that are essential to be changed β»οΈ please kindly contact π us through Zoom or Slack, I am available on Microverse UTC-6 time zone.