Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display joined missions in My profile view #42

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

NitBravoA92
Copy link
Owner

Hi @Kidd254

🎏 In this implementation, I:

βœ… Create the JoinedMissions component to render the list of Joined Missions that the user has. In this component, I use the useSelector hook to get the data from the missions state.

βœ… Import the JoinedMissions components inside the MyProfile view component to display the list of Joined Missions on the page

βœ… Add the CSS styles to improve the design of the MyProfile page

βœ… Update the responsive styles of the application

βœ… Update the README.md file to keep the documentation updated with the latest and future implementations

⭐To the code reviewer πŸ‘¨β€πŸ’»

πŸ’ I really thank πŸ™‡β€β™‚οΈ you, dear code reviewer πŸ‘¨β€πŸŽ¨ for dedicating your precious πŸ₯‡ time ⌚ to check the PR 🧾 .

I kindly ask πŸ™ dear code reviewer 🀡 that if there is any kind of issue 🦯 in this project, please do list πŸ“ƒ them in a descriptive πŸ’‘ manner and give your best suggestions 🎁 if needed.

If you think there are some big issues that are essential to be changed ♻️ please kindly contact πŸ“ž me through Zoom or Slack, I am available on Microverse UTC-6 time zone.

Copy link
Collaborator

@Kidd254 Kidd254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Project Approved! πŸ†

Hi @NitBravoA92 πŸ‘‹

Your project milestone is complete! βœ”οΈβœ” , it looks great πŸ”₯πŸ”₯πŸ”₯πŸ”₯ 🏁

Your code was very professional πŸ’―

There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Highlights 🌟

  • βœ”οΈ Descriptive commmit messsages

  • βœ”οΈ Descriptive PR description

  • βœ”οΈ No linter Errors

  • The code is top-notch! πŸ’― and have a huge potential.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Important Notes πŸ“

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NitBravoA92
Copy link
Owner Author

@Kidd254 Thanks for reviewing the code.

@NitBravoA92 NitBravoA92 merged commit 3886c9c into dev Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants