Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missions conditional components #39

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

Kidd254
Copy link
Collaborator

@Kidd254 Kidd254 commented Jul 25, 2023

In this pull request I:

  • Added a display of the correct mission button and badge using conditional rendering syntax
  • Updated the CSS styles of the missions badges

Copy link
Owner

@NitBravoA92 NitBravoA92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kidd254,

Excellent Job!

Everything works perfectly fine and meets all the requirements of the task.

There is nothing else to do other than... merge it :shipit:

Congratulations! 🎉

Highlights

✅ You used Gitflow correctly 👍

✅ No linter error 👍

✅ Good commit messages 👍

✅ Good descriptive PR 👍

✅ Great Job using the conditional rendering syntax.

✅ You did all the necessary implementations to render the correct mission button and badge 👍

✅ Good Job updating the CSS styles to display the missions' badges correctly. 👏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

@Kidd254 Kidd254 merged commit 52143c4 into dev Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants