Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rocket booking cancelation #38

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

NitBravoA92
Copy link
Owner

Hi @Kidd254

🎏 In this PR, I:

βœ… Create the action: cancelReserve in the rockets reducer to change the reserved status to false on a rocket item

βœ… Create a handle function called handleClickCancelReserve

βœ… Dispatch the action: cancelReserve inside the handleClickCancelReserve function adding the rocket ID as a parameter.

βœ… Add an onClick event on the Cancel Reservation button to call the handleClickCancelReserve function when the user clicks on that button.

βœ… Update the Future Features section README.md file

⭐To the code reviewer πŸ‘¨β€πŸ’»

πŸ’ I really thank πŸ™‡β€β™‚οΈ you, dear code reviewer πŸ‘¨β€πŸŽ¨ for dedicating your precious πŸ₯‡ time ⌚ to check the PR 🧾 .

I kindly ask πŸ™ dear code reviewer 🀡 that if there is any kind of issue 🦯 in this project, please do list πŸ“ƒ them in a descriptive πŸ’‘ manner and give your best suggestions 🎁 if needed.

If you think there are some big issues that are essential to be changed ♻️ please kindly contact πŸ“ž me through Zoom or Slack, I am available on Microverse UTC-6 time zone.

Copy link
Collaborator

@Kidd254 Kidd254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NitBravoA92 ,

Approved 🟒 🟒

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰
giphy

Highlights

  • Previous react components works fineπŸ’―
  • Setup redux store correrctlyπŸ‘
  • Followed ducks pattern🟒 πŸ‘

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NitBravoA92 NitBravoA92 merged commit f97cd84 into dev Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants