Render the Rockets lists in the UI #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the state using useSelector
Kidd254
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
🟢 Project Approved! 🏆
Hi @NitBravoA92 👋
Your project is complete! ✔️✔ , it looks great 🔥🔥🔥🔥 🏁
Your code was very professional 💯
There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights 🌟
-
✔️ Descriptive commit messages
-
✔️ Descriptive PR description
-
✔️ No linter Errors
-
The code is top-notch! 💯 and have a huge potential.
Cheers and Happy coding!👏👏👏
Important Notes 📝
- Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
- Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
@Kidd254 Thank you very much for taking the time to review this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Kidd254
🎏 In this PR, I:
✅ Create an extra validation in the pending, fulfilled, and rejected actions before updating the rockets state
✅ Create the RocketItem component to display a rocket item
✅ Create the RocketsContent component and import the RocketItem component to display a list of rockets saved on the state using useSelector hook.
✅ Import the RocketsContent component and Import the Rocket.css file in the Rockets view component
✅ Update the general CSS styles of the application
✅ Create the CSS styles of the Rockets view to make the UI looks better.
⭐To the code reviewer 👨💻
💝 I really thank 🙇♂️ you, dear code reviewer 👨🎨 for dedicating your precious 🥇 time ⌚ to check the PR 🧾 .
I kindly ask 🙏 dear code reviewer 🤵 that if there is any kind of issue 🦯 in this project, please do list 📃 them in a descriptive 💡 manner and give your best suggestions 🎁 if needed.
If you think there are some big issues that are essential to be changed ♻️ please kindly contact 📞 me through Zoom or Slack, I am available on Microverse UTC-6 time zone.