Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Rockets data from API #32

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Fetch Rockets data from API #32

merged 4 commits into from
Jul 25, 2023

Conversation

NitBravoA92
Copy link
Owner

@NitBravoA92 NitBravoA92 commented Jul 24, 2023

Hi @Kidd254

🎏 In this PR, I:

done

βœ… Use the Axios library to fetch the Rockets data from the API.

βœ… Use the createAsyncThunk function to handle the asynchronous request to the API

βœ… Create actions for each status of the request (pending, fulfilled, and rejected) and thus update the state of rockets.

βœ… Use of useDispatch in the Rockets component to call the action getAllRockets that gets the data and thus checks that everything works correctly.

βœ… Update the CSS styles of the Navigation Menu

βœ… Update the README.md file

⭐To the code reviewer πŸ‘¨β€πŸ’»

πŸ’ I really thank πŸ™‡β€β™‚οΈ you, dear code reviewer πŸ‘¨β€πŸŽ¨ for dedicating your precious πŸ₯‡ time ⌚ to check the PR 🧾 .

I kindly ask πŸ™ dear code reviewer 🀡 that if there is any kind of issue 🦯 in this project, please do list πŸ“ƒ them in a descriptive πŸ’‘ manner and give your best suggestions 🎁 if needed.

If you think there are some big issues that are essential to be changed ♻️ please kindly contact πŸ“ž me through Zoom or Slack, I am available on Microverse UTC-6 time zone.

Copy link
Collaborator

@Kidd254 Kidd254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟒 Project Approved! πŸ†

Hi @NitBravoA92 πŸ‘‹

Your project is complete! βœ”οΈβœ” , it looks great πŸ”₯πŸ”₯πŸ”₯πŸ”₯ 🏁

Your code was very professional πŸ’―

There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Highlights 🌟

  • βœ”οΈ Descriptive commmit messsages

  • βœ”οΈ Descriptive PR description

  • βœ”οΈ No linter Errors

  • The code is top-notch! πŸ’― and have a huge potential.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Important Notes πŸ“

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NitBravoA92 NitBravoA92 requested a review from Kidd254 July 25, 2023 06:53
@NitBravoA92
Copy link
Owner Author

Hi @Kidd254
I kindly ask you to mark the PR as Approved.

@NitBravoA92 NitBravoA92 merged commit cd1c6fe into dev Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants