Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGP8 compatibility #48

Merged
merged 6 commits into from
Oct 28, 2023
Merged

AGP8 compatibility #48

merged 6 commits into from
Oct 28, 2023

Conversation

deckerst
Copy link
Contributor

Main change is adding namespace for AGP8 compatibility.
Rest is upgrades so that the example can compile on a modern setup with recent Flutter/Gradle.

Copy link
Owner

@Nimrodda Nimrodda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left some comments.
Also have you verified the the example app works?

@@ -55,7 +55,7 @@ android {

defaultConfig {
applicationId "com.nimroddayan.flutternsd.example"
minSdkVersion 23
minSdkVersion 21
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the existing minimum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. By the way, is there a reason for this minimum?

}

dependencies {
classpath 'com.android.tools.build:gradle:4.0.1'
classpath 'com.android.tools.build:gradle:7.3.1'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title says AGP 8 but I see 7 here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGP 8 compatibility is for consumer projects using AGP 8.
Here changing to 7 was not necessary for AGP 8 compatibility, but just part of general upgrades from ancient versions used in this repo.

@deckerst
Copy link
Contributor Author

Also have you verified the the example app works?

Yes. And this fix for AGP8 has been used in many repos already.

@Nimrodda
Copy link
Owner

checks failed Because flutter_nsd_example depends on cupertino_icons >=1.0.6 which requires SDK version >=2.19.0 <4.0.0, version solving failed.. Let's address that before I merge this.

@deckerst
Copy link
Contributor Author

Interesting. In my environment I use a recent Dart SDK which requires null safety, so I needed to bump cupertino_icons version to make it build. But your GitHub workflow uses an old Dart SDK (< 2.19.0). That Dart SDK version depends on the Flutter version you specified in env.FLUTTER_VERSION which is setup at the repo level. So my understanding is that you can bump that FLUTTER_VERSION. Otherwise, feel free to reject this PR.

@Nimrodda
Copy link
Owner

Interesting. In my environment I use a recent Dart SDK which requires null safety, so I needed to bump cupertino_icons version to make it build. But your GitHub workflow uses an old Dart SDK (< 2.19.0). That Dart SDK version depends on the Flutter version you specified in env.FLUTTER_VERSION which is setup at the repo level. So my understanding is that you can bump that FLUTTER_VERSION. Otherwise, feel free to reject this PR.

I use FVM for Flutter versioning. Could you please update it and we see if it fixes the issue?

@Nimrodda Nimrodda merged commit 9731fd9 into Nimrodda:master Oct 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants