-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGP8 compatibility #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left some comments.
Also have you verified the the example app works?
example/android/app/build.gradle
Outdated
@@ -55,7 +55,7 @@ android { | |||
|
|||
defaultConfig { | |||
applicationId "com.nimroddayan.flutternsd.example" | |||
minSdkVersion 23 | |||
minSdkVersion 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the existing minimum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. By the way, is there a reason for this minimum?
} | ||
|
||
dependencies { | ||
classpath 'com.android.tools.build:gradle:4.0.1' | ||
classpath 'com.android.tools.build:gradle:7.3.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title says AGP 8 but I see 7 here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AGP 8 compatibility is for consumer projects using AGP 8.
Here changing to 7 was not necessary for AGP 8 compatibility, but just part of general upgrades from ancient versions used in this repo.
Yes. And this fix for AGP8 has been used in many repos already. |
checks failed |
Interesting. In my environment I use a recent Dart SDK which requires null safety, so I needed to bump |
I use FVM for Flutter versioning. Could you please update it and we see if it fixes the issue? |
Main change is adding namespace for AGP8 compatibility.
Rest is upgrades so that the example can compile on a modern setup with recent Flutter/Gradle.