Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

308 implement basic logup algorithm #327

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martun
Copy link
Contributor

@martun martun commented Feb 12, 2025

This is an implementation of the basic version of LogUp in the lookup argument. It also optimized lookup input calculation.

We should do the same in the permutation argument later, here's a task for that:

https://www.notion.so/nilfoundation/Implement-logUp-like-structure-in-permutation-argument-and-remove-unnecessary-values-like-lookup_pa-19ec61485260801bb249d2ea9fda05f4

@martun martun self-assigned this Feb 12, 2025
@martun martun linked an issue Feb 12, 2025 that may be closed by this pull request
@martun martun marked this pull request as draft February 12, 2025 07:43
@martun martun force-pushed the 308-implement-basic-logup-algorithm branch 9 times, most recently from 4efc6fc to a2a609e Compare February 17, 2025 15:01
@martun martun force-pushed the 308-implement-basic-logup-algorithm branch from a2a609e to ca6f772 Compare February 17, 2025 15:02
@martun martun force-pushed the 308-implement-basic-logup-algorithm branch from ca6f772 to ba37edf Compare February 17, 2025 15:03
Copy link

github-actions bot commented Feb 17, 2025

Clang Test Results

  177 files  ± 0    177 suites  ±0   23m 2s ⏱️ -12s
8 453 tests  - 96  8 447 ✅  - 96  6 💤 ±0  0 ❌ ±0 
8 519 runs   - 96  8 513 ✅  - 96  6 💤 ±0  0 ❌ ±0 

Results for commit 0a226d8. ± Comparison against base commit b95c1b9.

This pull request removes 105 and adds 9 tests. Note that renamed tests count towards both.
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
pack_equal_test_suite ‑ bubb_to_bulb_1
pack_equal_test_suite ‑ bubb_to_bulb_2
pack_equal_test_suite ‑ bubb_to_lubb_1
…
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4
placeholder_circuit4_lookup_test ‑ circuit3
placeholder_circuit4_lookup_test ‑ circuit4
polynomial_dfs_operations_with_constants_test_suite ‑ polynomial_dfs_inverse_test

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 17, 2025

Gcc Test Results

  177 files  ±0    177 suites  ±0   20m 24s ⏱️ - 2m 35s
8 546 tests  - 1  8 540 ✅  - 1  6 💤 ±0  0 ❌ ±0 
8 612 runs   - 8  8 606 ✅  - 8  6 💤 ±0  0 ❌ ±0 

Results for commit 0a226d8. ± Comparison against base commit b95c1b9.

This pull request removes 6 and adds 5 tests. Note that renamed tests count towards both.
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
placeholder_circuit3_lookup_test ‑ lookup_test
placeholder_circuit4_lookup_test ‑ lookup_test
blueprint_plonk_test_suite ‑ blueprint_plonk_hashes_keccak_round_bbf_not_random_pallas
blueprint_plonk_test_suite ‑ blueprint_plonk_hashes_keccak_round_bbf_random_pallas
placeholder_circuit4_lookup_test ‑ circuit3
placeholder_circuit4_lookup_test ‑ circuit4
polynomial_dfs_operations_with_constants_test_suite ‑ polynomial_dfs_inverse_test

♻️ This comment has been updated with latest results.

@martun martun requested a review from ETatuzova February 18, 2025 07:36
@martun martun marked this pull request as ready for review February 18, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basic LogUp algorithm
1 participant