157 review eq operators #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vo-nil
force-pushed
the
157-review-eq-operators
branch
from
51dd91a
to
ec0ecf0
Compare
vo-nil
force-pushed
the
157-review-eq-operators
branch
2 times, most recently
from
b985367
to
9e32359
Compare
vo-nil
force-pushed
the
157-review-eq-operators
branch
2 times, most recently
from
e5042af
to
246a62b
Compare
vo-nil
force-pushed
the
157-review-eq-operators
branch
3 times, most recently
from
96ae780
to
e33676e
Compare
martun
reviewed
May 20, 2024
include/nil/crypto3/algebra/curves/detail/edwards/element_g2.hpp
Outdated
Show resolved
Hide resolved
martun
reviewed
May 20, 2024
include/nil/crypto3/algebra/curves/detail/forms/edwards/inverted/add_2007_bl.hpp
Outdated
Show resolved
Hide resolved
|
vo-nil
force-pushed
the
157-review-eq-operators
branch
from
f048839
to
f1451d5
Compare
martun
reviewed
May 21, 2024
include/nil/crypto3/algebra/curves/detail/forms/montgomery/element_g1_affine.hpp
Outdated
Show resolved
Hide resolved
martun
reviewed
May 21, 2024
include/nil/crypto3/algebra/curves/detail/forms/short_weierstrass/element_g1_affine.hpp
Show resolved
Hide resolved
Added eq-operators for fields #157 Removed division operator data[2] typo #157 Work on curve operations #157 Arithmetic errors fixed #157 Removed comments #157 Removed divisions from hash_to_curve #157 work in progress #157 Reworked dobule and add functions to inplace variants #157 Update for short weierstrass curves #157 Renamed functions to emphasise inplace operation #157 Added type traits and different implementations for curves that support mixed_add #157 twisted extended #157 Replace double with double_inplace for multiexp and wnaf #157 renamed typetrait, removed doubling and mixed_add from static tests #157 disable curves_static test, update on fields #157 Clear version conflict markers #157 work in progress Good data for babyjubjub montgomery affine #157 Good data for jubjub montgomery affine #157 Fixed montgomery affine functions #157 remove space #157 Reworked add/dbl/madd to return void #157 void mixed_add for element_g2 #157 Reverted EC_INF define, updated addition and doubling function for g2 #157 Revert "Reverted EC_INF define, updated addition and doubling function for g2 #157" This reverts commit 46824d3. reverted g2 operations #157 rewrite for clarity #157 updates for blueprint compatibility #157 reworked operator+ #157
vo-nil
force-pushed
the
157-review-eq-operators
branch
from
23aab57
to
2aa6414
Compare
martun
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.