Remove hardcoded lines in additional shop item lore

NiklasEi · Feb 11, 2021 · 8fb0a64 · 8fb0a64
1 parent f9aae36
commit 8fb0a64
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 3.3.0
+- Removed hardcoded parts in additional lore for shop items
+  - the default items where adapted to include the previously hardcoded lines
+
 ## 3.2.0
 - extend GameRuleMultiRewards to support CookieClicker rewards
 

diff --git a/pom.xml b/pom.xml
@@ -8,7 +8,7 @@
     <artifactId>gamebox</artifactId>
     <name>GameBox</name>
     <packaging>jar</packaging>
-    <version>3.2.0</version>
+    <version>3.3.0</version>
     <description>Collection of inventory games</description>
     <url>https://gamebox.nikl.me</url>
 

diff --git a/src/main/java/me/nikl/gamebox/inventory/shop/Category.java b/src/main/java/me/nikl/gamebox/inventory/shop/Category.java
@@ -193,9 +193,6 @@ private ItemStack getButtonItem(ItemStack itemStack, ConfigurationSection pageSe
     }
     if (pageSection.isList(path + ".additionalLore")) {
       List<String> lore = new ArrayList<>();
-      lore.add(" ");
-      lore.add(ChatColor.GOLD + "- - - - - - - - - - - - - - - - - - -");
-      lore.add(" ");
       List<String> addLore = new ArrayList<>(pageSection.getStringList(path + ".additionalLore"));
       for (int i = 0; i < addLore.size(); i++) {
         addLore.set(i, StringUtility.color(addLore.get(i)));

diff --git a/src/main/resources/tokenShop.yml b/src/main/resources/tokenShop.yml
@@ -85,6 +85,9 @@ shop:
 
             # optional lore added to the default shop lore that already contains the price of the item/command
             additionalLore:
+              - ""
+              - "&6- - - - - - - - - - - - - - - - - - -"
+              - ""
               - "&bPersonal greeting by the server"
               - ""
               - "&bHave the permissions:"
@@ -131,6 +134,9 @@ shop:
           tokens: 1
           buttonItem:
             additionalLore:
+              - ""
+              - "&6- - - - - - - - - - - - - - - - - - -"
+              - ""
               - "&bYou need the following permission"
               - "&b  to buy this item:"
               - " "
@@ -154,6 +160,9 @@ shop:
             materialData: "nether_star"
             displayName: "&9&lExample Command"
             additionalLore:
+              - ""
+              - "&6- - - - - - - - - - - - - - - - - - -"
+              - ""
               - "&bIf you buy this, the server"
               - "&b  will thank you ;)"
               - " "
@@ -180,6 +189,9 @@ shop:
             materialData: "obsidian"
             displayName: "&9&lExample give Command"
             additionalLore:
+              - ""
+              - "&6- - - - - - - - - - - - - - - - - - -"
+              - ""
               - "&bGives you 59 obsidian per command"
               - "   &bIf you have the perm."
               - "   &6my.server.builder"