Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to urgent low soon alert #3486

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented May 25, 2024

I have 2 concerns with what we have now.

1- There are individuals who see the word "Forecast" and assume that this is a simulation.
2- There is no way to know if this alert takes into account the insulin on board or the carbs on board, which it doesn't.

This PR renames a few phrases in order to clarify that this is not a simulation and as such also does not take into account insulin on board or carbs on board.

The following image shows what it will look like in English.

Edit: This image is outdated. Please see the post below for the update.
Screenshot_20240525-121724

The title "Urgent Low Soon Alert" is used by Dexcom:
Screenshot 2024-05-25 122421

Those who have already used the Dexcom app may find it easier to understand what the alert is if they have seen the title before.

All in all, my intent is to help xDrip users understand this very important and useful alert better.

@Navid200 Navid200 marked this pull request as draft May 25, 2024 16:49
@Navid200
Copy link
Collaborator Author

Screenshot_20240525-180625

@Navid200 Navid200 marked this pull request as ready for review May 25, 2024 22:13
@olorinmaia
Copy link
Contributor

Excellent explanation and will make this alert more understandable for most users.

@jamorham
Copy link
Collaborator

I think what you're suggesting here is copying the design of a manufactures app which I do not think is a good idea especially as we're using a different mechanism for this type of alert. I also find the wording used in the proposed description quite confusing. I'm not against updating it but I don't think this is the right change to make.

Also we could take in to account the other aspects IOB/carb simulation for the alarm which was the original intention when I implemented that feature but the existing trend based algorithm appeared to be very effective without needing any user input which is why it remains that way so far.

@Navid200
Copy link
Collaborator Author

I suppose when the time comes that this alert will take insulin and carbs also into account, if a user does not enable xDrip predictive simulations, like me, the alert will behave exactly as it does now.
Anyway, that is something that will happen in the future. Who knows when? Let's worry about that day when that day comes.

The only reason I want to rename this is that it is not clear what it does.
Let me think about an alternative set of phrases.

@Navid200 Navid200 marked this pull request as draft May 28, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants