-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scipy transformation #57
Scipy transformation #57
Conversation
@NielsRogge It is good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, does this affect the logits check in the conversion script? If so, how much do they differ?
Feel free to update the conversion script
Co-authored-by: NielsRogge <[email protected]>
@NielsRogge Hi niels. I think your https://huggingface.co/datasets/nielsr/test-image/blob/main/vitpose_batch_data.pt is somehow outdated and gives
I need you to confirm or change this pt |
Hmm so that should normally still work from my branch. Let me try:
Yes confirmed. So the pixel values won't be the same anymore with this PR, so we can probably remove that check. Could you tell how much they differ? |
@NielsRogge Two things to share
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Great work
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.