forked from huggingface/transformers
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a test to match author's tokenization #37
Open
SaulLu
wants to merge
15
commits into
NielsRogge:modeling_markuplm_bis
Choose a base branch
from
SaulLu:modeling_markuplm_bis
base: modeling_markuplm_bis
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add a test to match author's tokenization #37
SaulLu
wants to merge
15
commits into
NielsRogge:modeling_markuplm_bis
from
SaulLu:modeling_markuplm_bis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@NielsRogge , I can't add you as a reviewer to this PR 🙂 . I would love to have your review on it |
fd1db5e
to
f05b861
Compare
47c172c
to
c79adea
Compare
5387164
to
738a608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I propose to add a test that aims to verify that we are able to reproduce the tokenization produced by the authors of MarkUpLM on the downstream task of WebSRC.
To design this test, I therefore ran the authors' code on the WebSRC downstream task and isolated:
get_xpath_and_treeid4tokens
methodhttps://github.com/microsoft/unilm/blob/e4929f812398207b7fefb4dda6e9debcb8ce34b9/markuplm/examples/fine_tuning/run_websrc/utils.py#L256-L284
convert_examples_to_features
method):https://github.com/microsoft/unilm/blob/e4929f812398207b7fefb4dda6e9debcb8ce34b9/markuplm/examples/fine_tuning/run_websrc/utils.py#L664-L684
This test already reveals some differences:
<s> question </s> content </s>
and we have<s> question </s></s> content
.