Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeInterval #238

Open
wants to merge 1 commit into
base: MP-noTimeInterval
Choose a base branch
from
Open

TimeInterval #238

wants to merge 1 commit into from

Conversation

jd-nictiz
Copy link
Contributor

@jd-nictiz jd-nictiz commented Feb 9, 2022

Trying to make the current situation of zib-TimeInterval visible.

The profiles either reference extension ext-TimeInterval.Period or (if the resource allows a Period) Period datatype profile zib-TimeInterval. ext-TimeInterval.Period is an extension with a valuePeriod which has zib-TimeInterval placed on it.

zib-TimeInterval contains extension ext-TimeInterval.Duration.

Previously (in the version that is currently at the Validatieraad), the 'Duration' and 'Period' extensions were added next to each other (or only the Duration extension was added when a Period element was already present) within the various profiles instead of nested. This situation would allow more 'control' over the cardinality of 'Duration` separate from Period.

Previously 2 (in the version that is currently at the Validatieraad), ext-TimeInterval.Duration had the comment:

Please note that when the zib concept Duration is known together with the zib concept startDateTime or a endDateTime, it should be communicated using a calculated Period. This element SHALL only be used if a Duration is known when neither startDateTime and endDateTime are known.

This has been removed, we could re-add the text using 'SHOULD'. Maybe even specifically add that it should only be used in v3 IVL_TS conversions?

(There is an nl-core-TimeInterval profile, but it isn't referenced from other nl-core-profiles. This is a situation should be fixed anyway, so I left it out of this comparison.)

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Validation report for changed materials

Validation

  • ❌ "Validate zib profiles" failed with 0 fatal messages, 1 errors, 0 warnings and 0 information messages.
  • ❌ "Validate zib extensions" failed with 0 fatal messages, 1 errors, 0 warnings and 0 information messages.
  • ❌ "Validate nl-core profiles" failed with 0 fatal messages, 1 errors, 10 warnings and 5 information messages.
  • ✔️ "Validate nl-core extensions" succeeded with 0 fatal messages, 0 errors, 0 warnings and 0 information messages.
  • ❌ "Validate other profiles" failed with 0 fatal messages, 3 errors, 0 warnings and 0 information messages.
  • ✔️ "Validate ConceptMaps" succeeded with 0 fatal messages, 0 errors, 0 warnings and 0 information messages.
  • ⚠️ "Validate other terminology" succeeded with 0 fatal messages, 0 errors, 27 warnings and 13 information messages.
  • ❌ "Validate examples" failed with 0 fatal messages, 36 errors, 36 warnings and 61 information messages.

Zib compliance

  • ❌ Zib compliance check failed with 0 errors and 3 warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants