replace emojione with emoji-toolkit #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetti
force-pushed
the
fix-unicode-emoji-rendering
branch
from
008b334
to
c24a1a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates EmojiOne to the new package that replaced it, emoji-toolkit, which includes more current emojis. This fixes many broken emojis that will never be fixed in EmojiOne due to its deprecation.
I noticed that the original emoji handler code was replacing EmojiOne's CDN with a local static copy. It wasn't clear to me where to get the same for emoji-toolkit, and I don't think committing 200+MB worth of PNGs to git would be the best idea. I've left it using their CDN for now.