An oversized file breaks successive files uploads if it is first photo processed for uploading (first dropped into the dropzone)

[pyhammond]

This fixes a bug where if the 1st file dropped into the dropzone was oversized (greater than the maxFilesize) then the successive photos would not properly process.

This was due to the "if" condition here returning "true" when it was the 1st file in the queue and the other files had not yet been "added" to the queue yet.

My fix waits for 1s now and re-checks to be sure the queue is still empty before emitting the "queuecomplete" event.

Behavior Description

If the first image dropped into the dropzone happens to be too large when compared against the maxFilesize setting, the rest of the files will not properly upload and will not fire a success event because the queuecomplete event gets called too early.

To Reproduce

To reproduce the behavior:

1. Create event handlers for the success, error and queuecomplete events in your init function used by dropzone.js
2. Set break points at the top of the the success and error event handler code from step 1
3. Drop multiple files into the dropzone - make sure the oversized photo is the first one to process
4. Notice that once the error callback is called once, the success callback never fires for the photos that were not oversized

This does not happen if the oversized photo is 2nd or later in the group of photos to process. It only happens if it is the 1st one to process.

[pyhammond]

Taken from an issue I posted at dropzone#2322

Nicolas asked me to create a pull request for my fix.

[NicolasCARPi]

Hello,

Thank you for submitting this pull request.

Unfortunately, I could not reproduce the issue. As you can see in this screenshot:

I upload a few too big files, and then there is a correct one. There is a queuecomplete event fired for each, which I do not understand why TBH. It should only fire once, right? (when uploading all files at once of course).

See the codepen (with current stable release):

https://codepen.io/Osef1212/pen/RNbQdgK

I suggest that you fork the codepen and provide code showing the issue at play, as I'm unable to for now :/

Cheers,
~Nico