ci: make the coverage job report what it finds - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs
CODECOV_TOKENin secrets before this merges, or the job goes red. Tell me if you'd rather have OIDC.codecov-action@v2uploads tokenless, tokenless is rate limited now, and v2 logs the 429 then exits 0 — so main's newest codecov report is still alpha.5 (#31), and every PR failscodecov/projectagainst that baseline. Hence v5 with a token,disable_search(v5 addsfiles:to what it discovers, and v2 was uploadingcoverage.ymlas a coverage file), andfail_ci_if_error.The job was silent when it failed, too:
coverage:lcovhad one reporter and it wrote to a file. Main's last run printedcleaning DB objects, exit 1, nothing else.Doesn't refresh the base by itself — main has to go green and push first.