Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next #2

Merged
merged 11 commits into from
Feb 22, 2024
Merged

Next #2

merged 11 commits into from
Feb 22, 2024

Conversation

msimerson
Copy link
Contributor

@msimerson msimerson commented Feb 20, 2024 •
edited
Loading

  • lib/mysql: DRY
  • init-mysql: added 'drop' CLI arg
  • ci: custom publish, b/c build test has SQL setup steps
  • test(user): remove duplicate setup code
  • test(user): add invalid user & pass tests
  • session ttl: set to 1 hour
  • feat(session.delete): added
  • test(session): add lifecycle tests
  • doc(README): added install section

@coveralls
Copy link

coveralls commented Feb 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8000901992

Details

  • -7 of 126 (94.44%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+10.0%) to 93.232%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/user.js 46 49 93.88%
routes/user.js 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
routes/user.js 1 91.84%
Totals Coverage Status
Change from base Build 7954557505: 10.0%
Covered Lines: 583
Relevant Lines: 607
💛 - Coveralls

@msimerson msimerson merged commit 99908d7 into main Feb 22, 2024
22 checks passed
@msimerson msimerson deleted the next branch February 22, 2024 07:30
@msimerson msimerson mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msimerson @coveralls