Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result modal working only on first table page #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MoshiMoshi0
Copy link
Contributor

@MoshiMoshi0 MoshiMoshi0 commented May 19, 2017

When using pagination, dataTables adds and removes <tr>'s from the DOM on every page change which causes new buttons to not have any 'click' callbacks.

The fix is to move the 'click' callback from each button to 'tbody' and use a selector instead.

Copy link
Contributor

@wenbinf wenbinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenbinf
Copy link
Contributor

wenbinf commented May 22, 2017

@swaggy could you merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants