Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Menu: Fix MNTM style battery percent off by 1 #339

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

956MB
Copy link
Member

@956MB 956MB commented Dec 31, 2024

What's new

#338

  • Uses the same furi_hal_power_get_pct function used on the desktop to fix the apparent rounding issue that's happening and show the same battery %.

Before

off-by-1-1

After

off-by-1-2


For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

- Uses the same `furi_hal_power_get_pct` function used on the desktop to fix the apparent rounded error that's happening and show the same battery %.
@956MB 956MB changed the title Battery: MNTM menu style battery off by 1 Main Menu: MNTM style battery percent off by 1 Dec 31, 2024
@GameLord2011
Copy link
Contributor

Checked on personal fork, is stable!

@Willy-JL Willy-JL added the bugfix Something isn't working label Jan 13, 2025
@Willy-JL Willy-JL changed the title Main Menu: MNTM style battery percent off by 1 Main Menu: Fix MNTM style battery percent off by 1 Jan 13, 2025
@Willy-JL Willy-JL merged commit 7d4ea20 into Next-Flip:dev Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants