-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub-GHz: Fix GPS "Latitute" typo, switch to "Lat" and "Lon" in .sub files #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change, existing files would not be parsed correctly after this change. if you want, you can add backwards support for the typo version
also there are others that rely on the broken spelling, since it has been there for so long. for example, hackrf portapack mayhem firmware has a wardrive map which supports flipper sub files with latitute typo. @htotoo might want to keep this in mind if we do go ahead |
Thanks for the ping, will check on it! |
Fair point, it is indeed a breaking change. Shall we then rather agree on keeping Then I think the switch makes more sense. |
Switched to "Lat","Lon" and looking for the older values in case they're not found. Added an extra check to make sure that we don't run in the null island problem when reading sub-files. |
Imho lat / lon seems a good solution also the fallback part. I'll implement it the same way in Portapack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
What's new
For the reviewer