Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-GHz: Fix GPS "Latitute" typo, switch to "Lat" and "Lon" in .sub files #246

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

m7i-org
Copy link
Contributor

@m7i-org m7i-org commented Oct 6, 2024

What's new

  • Fixed a typoin the SubGHz GPS coordinates for reading/writing sub files

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change, existing files would not be parsed correctly after this change. if you want, you can add backwards support for the typo version

@Willy-JL Willy-JL marked this pull request as draft October 7, 2024 03:08
@Willy-JL Willy-JL added the bugfix Something isn't working label Oct 7, 2024
@Willy-JL
Copy link
Member

Willy-JL commented Oct 7, 2024

also there are others that rely on the broken spelling, since it has been there for so long. for example, hackrf portapack mayhem firmware has a wardrive map which supports flipper sub files with latitute typo. @htotoo might want to keep this in mind if we do go ahead

@htotoo
Copy link
Contributor

htotoo commented Oct 7, 2024

Thanks for the ping, will check on it!

@m7i-org
Copy link
Contributor Author

m7i-org commented Oct 7, 2024

Fair point, it is indeed a breaking change.

Shall we then rather agree on keeping "Latitute","Longitude" retro-compatible for reading sub files and moving on to "Lat","Lon" for reading/writing from now on?

Then I think the switch makes more sense.

@m7i-org
Copy link
Contributor Author

m7i-org commented Oct 7, 2024

Switched to "Lat","Lon" and looking for the older values in case they're not found.

Added an extra check to make sure that we don't run in the null island problem when reading sub-files.

@htotoo
Copy link
Contributor

htotoo commented Oct 7, 2024

Imho lat / lon seems a good solution also the fallback part. I'll implement it the same way in Portapack.

@Willy-JL Willy-JL marked this pull request as ready for review October 8, 2024 03:50
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Willy-JL Willy-JL changed the title Fix GPS "Latitude" string Sub-GHz: Fix GPS "Latitute" typo, switch to "Lat" and "Lon" in .sub files Oct 8, 2024
@Willy-JL Willy-JL merged commit ae70945 into Next-Flip:dev Oct 8, 2024
2 checks passed
@m7i-org m7i-org deleted the fix/fix-typo branch October 10, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants