Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing icons to make all backgrounds consistent #162

Closed
wants to merge 2 commits into from

Conversation

skyhawkillusions
Copy link
Contributor

What's new

I went through the files in the icons and changed them all to have a white background, where they were either transparent or orange, for consistency

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL
Copy link
Member

@skyhawkillusions thanks for the PR! i would rather you submit this kind of change to official firmware repo, since it brings no tangible advantage after compilation, and since the files differ from official firmware ones it will cause merge conflicts and confusion if things change upstream (dealing with these is of course possible, im just saying that dealing with them is more annoying than having some icons orange or transaprent - if instead upstream merges this, then we are all on the same page)

@skyhawkillusions
Copy link
Contributor Author

@skyhawkillusions thanks for the PR! i would rather you submit this kind of change to official firmware repo, since it brings no tangible advantage after compilation, and since the files differ from official firmware ones it will cause merge conflicts and confusion if things change upstream (dealing with these is of course possible, im just saying that dealing with them is more annoying than having some icons orange or transaprent - if instead upstream merges this, then we are all on the same page)

flipperdevices/flipperzero-firmware#3802 The devs are currently automating the conversion to 1-bit images

@Willy-JL
Copy link
Member

Willy-JL commented Aug 2, 2024

since this is being handled in OFW build process, i will close the PR here. still, thank you!

@Willy-JL Willy-JL closed this Aug 2, 2024
@Willy-JL Willy-JL added duplicate This issue or pull request already exists enhancement New enhancement or request labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants