Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NERD tutorials #1722

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

NERD tutorials #1722

wants to merge 10 commits into from

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Jul 17, 2023

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Adding both a detailed and a high level tutorial regarding NERD and TermSet.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

No tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1
Copy link
Collaborator Author

mavaylon1 commented Jul 17, 2023

@oruebel @rly This is the very detailed tutorial notebook that I am finishing up today. It's the updated presentation notebook. This branch will also house the more digestible tutorials that focus on just using it and not the details.

This notebook reads in multple nwb files. How should that be handled? Link them to the dandi source for local download? Some are in the drive as well.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1722 (b9c7775) into dev (bede7c3) will not change coverage.
Report is 6 commits behind head on dev.
The diff coverage is n/a.

❗ Current head b9c7775 differs from pull request most recent head 3b611a1. Consider uploading reports for the commit 3b611a1 to get more accurate results

@@           Coverage Diff           @@
##              dev    #1722   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          27       27           
  Lines        2602     2602           
  Branches      680      680           
=======================================
  Hits         2393     2393           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.32% <ø> (ø)
unit 83.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mavaylon1 mavaylon1 self-assigned this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant